Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tda] code to get latest mobile release from monorepo #313

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

realkosty
Copy link
Collaborator

@realkosty realkosty commented Nov 3, 2023

Background

We want this so that we are able to move mobile repos into empower.
As you can tell by reading the code this is a bit hacky since GitHub doesn't seem to order release versions/tags very well when using <platform>-1.2.3 format. It has been useful to have release history for debugging purposes and release notes. but not sure if it's worth making it work properly or whether we should just have 1 latest release version at a time for each platform.
If there is a release version format that GitHub understands and sorts correctly (alphanumeric) - this would be easier, but I spent a good 20 minutes researching and wasn't able to find such format

Testing

  1. Change code:
GITHUB_REPOS = {
    ...
    'ios': 'empower'
}
  1. Create some test releases in empower
  2. Run
python3 ./latest_github_release.py ios
ios-0.0.23

@realkosty realkosty force-pushed the tda-mobile-release-from-empower branch from 4896594 to ba7740d Compare November 3, 2023 23:22
Copy link
Collaborator

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@realkosty realkosty marked this pull request as draft November 27, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants