Moved components and fixed loading spinner #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #616 +/- ##
=======================================
Coverage 36.30% 36.30%
=======================================
Files 37 37
Lines 865 865
Branches 109 109
=======================================
Hits 314 314
Misses 532 532
Partials 19 19
|
lukemun
reviewed
Oct 31, 2024
| @@ -1,11 +1,13 @@ | |||
| 'use client' | |||
|
|
|||
| import Loader from 'react-loader-spinner'; | |||
There was a problem hiding this comment.
Could we keep this 3 dot loader in the /ui directory? General purpose reusable components should live there and custom made ones for a particular page should be in /components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
componentsdir