-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] view madness in seqan2 #190
Conversation
For some reason, we seem to be loosing gap symbols 🙈 |
Why do all tests fail? 🤔 And what does it mean for us that we are losing gap symbols? |
Because we are losing gap symbols!
That the tests fail 😜 I will have a look at it later today! No need to review anything yet |
Makes sense 😄 |
ready for review now! |
edit3: all failures were related to static builds. I have deactivated them again. |
fixes #189
SeqAn2 deep internally expects things to be default-constructible which some of our view are no longer. It is also no longer possible to workaround this... but it is possible to specialise lots of stuff within in SeqAn2 to not trigger any default-initialisations which is super-unsafe... but works ™️
SeqAn2 is both 💩 and 🎉 because while the craziness is infinite, you can always work around it, by adding more 💩