Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] view madness in seqan2 #190

Merged
merged 4 commits into from
Sep 24, 2022
Merged

[fix] view madness in seqan2 #190

merged 4 commits into from
Sep 24, 2022

Conversation

h-2
Copy link
Member

@h-2 h-2 commented Sep 21, 2022

fixes #189


SeqAn2 deep internally expects things to be default-constructible which some of our view are no longer. It is also no longer possible to workaround this... but it is possible to specialise lots of stuff within in SeqAn2 to not trigger any default-initialisations which is super-unsafe... but works ™️


SeqAn2 is both 💩 and 🎉 because while the craziness is infinite, you can always work around it, by adding more 💩

@h-2 h-2 requested a review from sarahet September 21, 2022 19:09
@h-2
Copy link
Member Author

h-2 commented Sep 21, 2022

For some reason, we seem to be loosing gap symbols 🙈

@sarahet
Copy link
Member

sarahet commented Sep 22, 2022

Why do all tests fail? 🤔 And what does it mean for us that we are losing gap symbols?

@h-2
Copy link
Member Author

h-2 commented Sep 22, 2022

Why do all tests fail?

Because we are losing gap symbols!

And what does it mean for us that we are losing gap symbols?

That the tests fail 😜

I will have a look at it later today! No need to review anything yet

@sarahet
Copy link
Member

sarahet commented Sep 22, 2022

Makes sense 😄

@h-2
Copy link
Member Author

h-2 commented Sep 22, 2022

ready for review now!

@h-2
Copy link
Member Author

h-2 commented Sep 22, 2022

  1. I know why the GCC+macOS test is failing, but I don't know why it didn't fail before. The problem is that the mdsum command is called just md5 on macOS and FreeBSD. How could this not have failed before,and why does it not fail on GCC11? edit: it does fail on all macOS compilers now
  2. I have no clue why the GCC10 tests on Linux fail. They pass on my GCC on my laptop. edit: It is exactly the BAM tests that are failing, so it is unrelated to the algorithm...

edit3: all failures were related to static builds. I have deactivated them again.

@h-2 h-2 merged commit f61d152 into seqan:lambda3 Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants