[fix] check presence of taxtree in index #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGSSGene
reviewed
Jan 9, 2024
src/mkindex_algo.hpp
Outdated
Comment on lines
594
to
595
| if (taxaWithoutNameCount * 100 / taxonNames.size() > 10) | ||
| std::cerr << "Warning: More than 10% of taxa have no valid name entry.\n"; |
There was a problem hiding this comment.
This might should be:
Suggested change
| if (taxaWithoutNameCount * 100 / taxonNames.size() > 10) | |
| std::cerr << "Warning: More than 10% of taxa have no valid name entry.\n"; | |
| if (taxaWithoutNameCount * 10 > taxonNames.size()) | |
| std::cerr << "Warning: More than 10% of taxa have no valid name entry.\n"; |
The issue is that taxaWithoutNameCount * 100 / taxonNames.size() might be 10.9 which will be rounded to 10 and then no warning will be given even though it's above 10%.
There was a problem hiding this comment.
Yeah, I mean the whole check / the exact value is not super-important, but you are right of course!
|
LGTM (minus Github mac test issues) |
sarahet
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.