Provide charset and collate options only for dialects supporting them #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WikiRik I'm not sure how to correct the typescript error |
|
You'll need to update the minimal type here to add the dialect property; https://github.com/sequelize/umzug/blob/main/src/storage/sequelize.ts#L21-L30 |
QuentinFarizon
force-pushed
the
charsetable_dialects
branch
from
ec2e321 to
06551c0
Compare
WikiRik
reviewed
Oct 29, 2023
QuentinFarizon
force-pushed
the
charsetable_dialects
branch
from
06551c0 to
91f705c
Compare
WikiRik
reviewed
Oct 31, 2023
QuentinFarizon
force-pushed
the
charsetable_dialects
branch
from
95024e9 to
da7aa27
Compare
WikiRik
reviewed
Oct 31, 2023
QuentinFarizon
force-pushed
the
charsetable_dialects
branch
from
da7aa27 to
ec0f898
Compare
|
We're one step further, now the linting issues commence |
QuentinFarizon
force-pushed
the
charsetable_dialects
branch
from
ec0f898 to
2796511
Compare
mmkal
requested changes
Oct 31, 2023
QuentinFarizon
force-pushed
the
charsetable_dialects
branch
from
2796511 to
c13f8a5
Compare
QuentinFarizon
force-pushed
the
charsetable_dialects
branch
from
c13f8a5 to
0575929
Compare
mmkal
approved these changes
Nov 3, 2023
|
Released in v3.4.0. |
|
Released in v3.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #612
Fixes #623