Fix "can not convert object to primitive" nonsence error message #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #697 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 12 12
Lines 1466 1473 +7
Branches 269 269
=======================================
+ Hits 1458 1465 +7
Misses 8 8 ☔ View full report in Codecov by Sentry. |
mmkal
reviewed
Feb 2, 2025
| @@ -705,7 +708,7 @@ describe('alternate migration inputs', () => { | |||
| ) | |||
|
|
|||
| await expect(umzug.down()).rejects.toThrowErrorMatchingInlineSnapshot( | |||
| `"Migration m1 (down) failed: Non-error value thrown. See info for full props: Some cryptic failure"`, | |||
There was a problem hiding this comment.
This removed test case is still important. Instead of changing it could you copy paste the test and update the duplicated one.
Comment on lines
+53
to
+58
| try { | ||
| return `${msg}: ${String(cause)}` | ||
| } catch { | ||
| //Null prototype object 'cause' would end up here | ||
| return msg | ||
| } |
There was a problem hiding this comment.
Is there a way to check explicitly for null prototype object without a try/catch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MikroOrm that uses umzug under the hood, throws custom errors in the form of objects derived from null (Null prototype objects) that are not handled correctly by errorString method, this result in confusing error message masking original error completely (nothing related to original error in stack trace)
This micro fix solves this and makes errorString more universal in handling such tricky objects.