Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to deserialize enums from SeqAccessDeserializer #2445

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add ability to deserialize enums from SeqAccessDeserializer #2445

wants to merge 8 commits into from

Commits on Oct 22, 2024

  1. Convert fn test_map_access_to_enum() to mod access_to_enum 

    (review this commit with "ignore whitespace changes" option on)
    @Mingun
    Mingun committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    4696e9d View commit details
    Browse the repository at this point in the history

  2. Use functional names for test types

    @Mingun
    Mingun committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    b8710ef View commit details
    Browse the repository at this point in the history

  3. Add tests for all possible enum forms

    @Mingun
    Mingun committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    931ac19 View commit details
    Browse the repository at this point in the history

  4. Add negative tests for MapAccessDeserializer

    @Mingun
    Mingun committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    51d56ca View commit details
    Browse the repository at this point in the history

  5. Change error message for an empty map from which enum is deserialized 

    The new message is more logical, because actually map *is* expected,
but it should contain at least one entry
    @Mingun
    Mingun committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    12821c0 View commit details
    Browse the repository at this point in the history

  6. Add tests for deserialization of enum from sequence 

    failures (6):
    access_to_enum::seq::empty_seq
    access_to_enum::seq::newtype
    access_to_enum::seq::struct_
    access_to_enum::seq::tuple
    access_to_enum::seq::unit
    access_to_enum::seq::wrong_tag
    @Mingun
    Mingun committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    bee09f1 View commit details
    Browse the repository at this point in the history

  7. Implement deserialization of enum from sequence using SeqAccessDeseri… 

    …alizer

Fixes all tests
    @Mingun
    Mingun committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    b5d6530 View commit details
    Browse the repository at this point in the history

  8. Better document SeqAccessDeserializer and MapAccessDeserializer

    @Mingun
    Mingun committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    20aa8e2 View commit details
    Browse the repository at this point in the history