another note

sergiitk · Mar 26, 2024 · 792a14e · 792a14e
1 parent 5272e44
commit 792a14e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/xds/src/main/java/io/grpc/xds/XdsServerWrapper.java b/xds/src/main/java/io/grpc/xds/XdsServerWrapper.java
@@ -455,6 +455,13 @@ private void shutdown() {
 
     private void updateSelector() {
       Map<FilterChain, AtomicReference<ServerRoutingConfig>> filterChainRouting = new HashMap<>();
+      // TODO(sergiitk): is this a good place to reset interceptors?
+      // for (FilterChain filterChain : savedRdsRoutingConfigRef.keySet()) {
+      //   if (!resourceName.equals(filterChain.httpConnectionManager().rdsName())) {
+      //     continue;
+      //   }
+      //
+      // }
       savedRdsRoutingConfigRef.clear();
       for (FilterChain filterChain: filterChains) {
         filterChainRouting.put(filterChain, generateRoutingConfig(filterChain));

diff --git a/xds/src/main/java/io/grpc/xds/internal/rlqs/RlqsClientPool.java b/xds/src/main/java/io/grpc/xds/internal/rlqs/RlqsClientPool.java
@@ -58,6 +58,8 @@ private RlqsClientPool(ScheduledExecutorService scheduler, int cleanupIntervalSe
 
   /** Creates an instance. */
   public static RlqsClientPool newInstance(ScheduledExecutorService scheduler) {
+    // TODO(sergiitk): scheduler - consider using GrpcUtil.TIMER_SERVICE.
+    // TODO(sergiitk): note that the scheduler has a finite lifetime.
     return new RlqsClientPool(scheduler, 0);
   }