Skip to content

Commit

Permalink
This is version 1.1.1.
Browse files Browse the repository at this point in the history
Avoid creating a TaskLoggingHelper if not needed.
This also brings better integration with the task, like its Log.HasLoggedErrors property works on top of Serilog.
  • Loading branch information
teo-tsirpanis committed Jul 6, 2019
1 parent 69d178c commit c1f4994
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Serilog.Sinks.MSBuild/MSBuildSink.cs
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public class MSBuildSink : ILogEventSink
public MSBuildSink(ITask task, IFormatProvider formatProvider = null)
{
_formatProvider = formatProvider;
_loggingHelper = new TaskLoggingHelper(task);
_loggingHelper = task is Task taskConcrete ? taskConcrete.Log : new TaskLoggingHelper(task);
}

/// <inheritdoc cref="ILogEventSink.Emit"/>
Expand Down
4 changes: 2 additions & 2 deletions Serilog.Sinks.MSBuild/Serilog.Sinks.MSBuild.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<Version>1.1.0</Version>
<Version>1.1.1</Version>
<TargetFrameworks>net45;netstandard2.0</TargetFrameworks>
<Title>Serilog sink for MSBuild</Title>
<Authors>Theodore Tsirpanis</Authors>
Expand All @@ -12,7 +12,7 @@
It is useful when an MSBuild task calls code that uses Serilog.</Description>
<PackageIconUrl>https://serilog.net/images/serilog-sink-nuget.png</PackageIconUrl>
<PackageProjectUrl>https://github.com/teo-tsirpanis/serilog-sinks-msbuild</PackageProjectUrl>
<PackageReleaseNotes>Add deeper integration with MSBuild.</PackageReleaseNotes>
<PackageReleaseNotes>Avoid creating a TaskLoggingHelper if not needed.</PackageReleaseNotes>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
Expand Down

0 comments on commit c1f4994

Please sign in to comment.