Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the project file to SDK format #10

Merged
merged 2 commits into from
Oct 15, 2020

Conversation

Numpsy
Copy link
Member

@Numpsy Numpsy commented Jul 26, 2020

Simply the result of running dotnet migrate.

I was looking at adding a netstandard2.0 target, but perhaps best done seperately afterwards?

(covers a bit of the same ground as the patch attached to #8)

@Numpsy
Copy link
Member Author

Numpsy commented Jul 26, 2020

Failed due to the CI build targetting a too old SDK :-(

@Numpsy
Copy link
Member Author

Numpsy commented Aug 4, 2020

Is it worth changing it to use PackageLicenseExpression instead of the URL at the same time?

@Numpsy
Copy link
Member Author

Numpsy commented Oct 12, 2020

@nblumhardt I'm not sure if anyone is watching this repository (the functionality is rather simple), but I see changes in other Serilog repositories adding extra targets to simplify the dependencies, so I think it's reasonable to update it. (I could also look at other build updates like PackageLicenceExpression, PackageIcon etc - not sure if it's better to do it all in one go, or in stages?)

@nblumhardt
Copy link
Member

Hi @Numpsy ! "Watched" again now :-)

Yes, I think those updates would make sense, and the help would be appreciated. Is this PR ready for a final review/merged, or do you want to build upon it some more?

@Numpsy Numpsy force-pushed the rw/migrate_project branch from a80d7d7 to 09b0496 Compare October 14, 2020 22:18
@Numpsy
Copy link
Member Author

Numpsy commented Oct 14, 2020

I was thinking to keep this one simple to just get it building with the current tools (my knowledge of appveyor etc is rather basic, so), and then do things like add the extra target framework and enable source link afterwards, so this is hopefully ok as is.

@nblumhardt nblumhardt merged commit d9523de into serilog:dev Oct 15, 2020
@nblumhardt
Copy link
Member

Thanks! 😎

@Numpsy Numpsy deleted the rw/migrate_project branch October 15, 2020 16:39
@nblumhardt nblumhardt mentioned this pull request Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants