Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull request template #62

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Add pull request template #62

merged 1 commit into from
Oct 26, 2018

Conversation

snowsignal
Copy link
Contributor

@snowsignal snowsignal commented Oct 26, 2018

What issue does this PR fix/close?

This closes one half of #20. (Issue templates still need to be added)

Describe what this PR does, briefly:

Make a cool template for future PRs! As a matter of fact, this PR uses the cool new template!

Check off the following items if you've done them:

  • This PR is ready for review (in other words, not a WIP)
  • New tests have been written to cover the new code in this PR (or your PR doesn't need tests)
  • Documentation has been added/changed to cover changes made (or your PR doesn't need new documentation)
  • This PR has been tested on a robot (optional, but it helps)

If your PR doesn't need new tests, explain why:

This doesn't change any code.

Do your changes break the public API of this library?

They do not.

@snowsignal snowsignal requested a review from andrewda as a code owner October 26, 2018 15:17
@andrewda andrewda merged commit 0421862 into master Oct 26, 2018
@andrewda andrewda deleted the pr-template branch October 26, 2018 21:35
andrewda pushed a commit that referenced this pull request Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants