Support deploying without a Dockerfile #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydrogers
added
the
⚡️ Enhancement
|
I like where this is going, but I see some other areas where I can improve. Let me keep this open and I will circle back to it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to be able to deploy spin projects that do not contain a Dockerfile. For example I have deployed a spin project with just containing a traefik service, allowing to deploy multiple web projects on a single server that use the same Traefik instance.
The
+e/-eis needed to make sure the deploy script doesnt exit when no dockerfile is found. This happens on Mac when ls is not returning any results. There might be a better way around this, I'm open for alternatives.