Deprecate connect() in favour of IpcConnector #380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce IpcConnector as a means of forcing at most one connect request to a one-shot server. For a smooth upgrade experience, deprecate new() and connect() in favour of new_with_connector() and its connect() method, respectively. new() will be deleted in a future release at which point new_with_connector() could be renamed new(). Note that new_with_connector() does not support all the usecases of new(), but should be sufficient for Servo. In particular, it does not support launching a process passing the name of a one-shot server to which the process may then connect. Ref: servo#378
jdm
reviewed
Jan 24, 2025
Yes, this only works with fork. Closing, but I think it would be worth capturing the spawn usecase in a testcase in this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft pull request prototypes a replacement for connect() with its unpredictable behaviour when called more than once per one-shot server.
Introduce IpcConnector as a means of forcing at most one connect request to a one-shot server.
For a smooth upgrade experience, deprecate new() and connect() in favour of new_with_connector() and its connect() method, respectively.
new() will be deleted in a future release at which point new_with_connector() could be renamed new().
Note that new_with_connector() does not support all the usecases of new(), but should be sufficient for Servo. In particular, it does not support launching a process passing the name of a one-shot server to which the process may then connect.
Ref: #378