layout2020: backdrop filter creates a stacking context #35415
+31
−1,746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaBrest
requested review from
mrobinson,
Loirooriol and
nicoburns
as code owners
JoshuaBrest
force-pushed
the
backdrop-filter-stacking-context
branch
from
41df431 to
3bd1e6a
Compare
|
🔨 Triggering try run (#13255612864) for Linux (WPT) |
|
Test results for linux-wpt-layout-2020 from try job (#13255612864): Flaky unexpected result (17)
Stable unexpected results that are known to be intermittent (17)
Stable unexpected results (9)
|
|
|
|
The It's just 2 passes so I guess I will just bump stylo to 8af5d515a03bfca5d19fcaa541783327673a951e |
Loirooriol
reviewed
Feb 11, 2025
You need to check this.
These changes require tests. Not necessarily new tests, existing tests are fine. But I only see parsing tests among the unexpected results. We need tests for:
|
I can't because I changed the stylo repo to point to my own.
Okay. |
JoshuaBrest
force-pushed
the
backdrop-filter-stacking-context
branch
2 times, most recently
from
d2c8a56 to
3d25ea2
Compare
|
What do you mean you can't run You should also rebase (there are conflicts).
Should say "stacking context and a containing block". |
cargo-deny fails with unapproved git forks present in Cargo.lock, and this is part of test-tidy. |
I'll wait to see if and when my PR in servo/stylo#121 lands then just rebase and return it to pointing to the stylo repo's latest tag. I'll force push, so my repo is never actually in the history (i don't think you guys squash and merge). |
|
Ah, interesting. |
Oh wow, that is so much smarter. I should've done that. |
Hold on, doesn't this defeat the whole purpose of disallowing unapproved forks? Couldn't someone just open a PR with malicious code and then close it, then just point it to the PR? I believe this would bypass that cargo tidy check. |
|
A malicious person could also edit |
So will you implement |
JoshuaBrest
force-pushed
the
backdrop-filter-stacking-context
branch
5 times, most recently
from
f658fa4 to
2339cbd
Compare
Loirooriol
requested changes
Feb 12, 2025
There was a problem hiding this comment.
You need to update test expectations: #35415 (comment)
You need test coverage for establishing a stacking context, and for establishing a containing block for abspos and fixedpos descendants.
|
I did it! |
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
JoshuaBrest
force-pushed
the
backdrop-filter-stacking-context
branch
from
e8451f4 to
1eb7bd2
Compare
|
Again: You need test coverage for establishing a stacking context, and for establishing a containing block for abspos and fixedpos descendants. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backdrop-filter now creates both a stacking context and a containing block context.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors