Add test for atom order stability #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, I tested it and this helps. |
mrobinson
requested changes
Feb 19, 2025
| /// Write generated code to destination [`Vec<u8>`] and return it as [`String`] | ||
| /// | ||
| /// Used mostly for testing or displaying a value. | ||
| pub fn write_to_string(&mut self, mut destination: Vec<u8>) -> io::Result<String> |
There was a problem hiding this comment.
Maybe this could be annotated with #[cfg(test)]. I think it isn't useful otherwise and this can help to avoid breaking API in the future.
There was a problem hiding this comment.
I annotated it, but it caused breakage in the test. So I converted tests to unit test.
# Conflicts: # string-cache-codegen/tests/reproducibility_test.rs
|
Yeah, we need to then make a release, and update html5ever, I guess. |
mrobinson
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates a source of non-reproducibility from codegen.
Used test to verify behavior and then fixed it via replacing
HashMap→BTreeMapto eliminate it. This should have no impact since it's at codegen.It affects servo/html5ever#573