Enable overflow:clip for Servo #111
Conversation
longvatrong111
force-pushed
the
overflow-clip
branch
from
860618a to
f54c445
Compare
longvatrong111
changed the title
| BorderBox, | ||
| } | ||
|
|
||
| impl Parse for OverflowClipBox { |
There was a problem hiding this comment.
I assume such trivial keyword parsers are auto-generated and we don't need a manual implementation here. Could you verify?
There was a problem hiding this comment.
Yes, I wanted to make it explicit.
But I've just realized this is not necessary for overflow : clip. Should implement parse for overflow-clip-margin instead
| @@ -134,7 +134,7 @@ ${helpers.predefined_type( | |||
|
|
|||
| ${helpers.single_keyword( | |||
| "-servo-overflow-clip-box", | |||
| "padding-box content-box", | |||
| "padding-box content-box border-box", | |||
There was a problem hiding this comment.
I don't see the point in having both -servo-overflow-clip-box and overflow-clip-box.
The former was implemented for legacy in servo/servo#9875 but later removed in servo/servo#16336.
So I would just remove -servo-overflow-clip-box in favor of the standard properties.
There was a problem hiding this comment.
I see. And it's not necessary for overflow:clip too. Will remove it.
This PR help
overflow : clipimplementation in Servooverflow : clipfor Servoborder-boxvalue foroverflow-clip-marginServo PR: servo/servo#35103
cc: @xiaochengh