New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fastrpc.dumps tests #34

Open

rembish wants to merge 1 commit into seznam:master from rembish:ar-tests

Contributor

rembish commented Aug 2, 2016

Hey there,

I wrote few tests for fastrpc.dumps method. Can you check 'em?

Alex


          fastrpc.dumps tests

005b567

Contributor

volca02 commented Jun 13, 2017

I tested this and it has issues on both python2 and python3

python2 whines "'ascii' codec can't encode characters in position 0-2: ordinal not in range(128)" - probably locale specific? Maybe binary strings would fit the binary buffers more?
python3 does not like the syntax on line 59 of test_dumps.py (SyntaxError: invalid syntax)

We have binary conformance tests implemented in core https://github.com/seznam/fastrpc/blob/master/test/frpc.tests - is there any other reason for the existence of this test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet