Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMS: after clicking Select Hospital, the keyboard focus is not reset when the selection page appears #242

Open
fwextensions opened this issue Oct 20, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@fwextensions
Copy link
Collaborator

  • enter a ringdown
  • click Select Hospital
  • press tab

result: the Send Ringdown button is focused.

expected: the first radio button in the hospital list should be selected.

@fwextensions fwextensions added the bug Something isn't working label Oct 20, 2022
@irqsyed irqsyed self-assigned this Feb 23, 2023
@holliskuang
Copy link
Collaborator

holliskuang commented Mar 15, 2023

Hi, took a look here. From what I can tell, the issue may stem from the way the Ringdown Form is structured:

{(Step 0) render }
{(Step 1) render }

{(Step 0) render }
{(Step 1) render }

When the SelectHospital button is selected, the focus jumps to the buttons and seems to remain there for the newly rendered components.

A solution may be to restructure the Step 0s together, then the Step 1s together:
{(Step 0) render }
{(Step 0) render }

{(Step 1) render }
{(Step 1) render }

Therefore, when the Select Hospital Button is clicked, the next tab will naturally be the Hospital Selections without having to mess with tabIndex. Unsure if there are any unintended consequences with this, but everything seems to work fine on my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants