Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMS: Keyboard focus #282

Closed
wants to merge 3 commits into from
Closed

EMS: Keyboard focus #282

wants to merge 3 commits into from

Conversation

holliskuang
Copy link
Collaborator

Reformatted how the Field/Selection components were structured

When the SelectHospital button is selected, the focus jumps to the buttons and seems to remain there for the newly rendered components.

Currently, it is set up as:
{(Step 0) render }
{(Step 1) render }

{(Step 0) render }
{(Step 1) render }

A solution may be to restructure the Step 0s together, then the Step 1s together.

{(Step 0) render }
{(Step 0) render }

{(Step 1) render }
{(Step 1) render }

Therefore, when the Select Hospital Button is clicked, the next tab will naturally be the Hospital Selections without having to mess with tabIndex. Unsure if there are any unintended consequences with this, but everything seems to work fine on my side.

@fwextensions
Copy link
Collaborator

@francisli any idea why this branch isn't triggering the CircleCI build?

@francisli
Copy link
Collaborator

@francisli any idea why this branch isn't triggering the CircleCI build?

I think because this is in a fork, and not in a branch on the main repository.

@holliskuang I've invited you to be a collaborator on the repo, so you can push up new branches directly to it (which should trigger a CircleCI build).

https://github.com/sfbrigade/bats-server/invitations

@holliskuang holliskuang closed this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants