Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features add #10

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Features add #10

wants to merge 15 commits into from

Conversation

knd2122
Copy link

@knd2122 knd2122 commented Jan 24, 2025

  • Add system serial number, Manufacturer, Product Name & UUID collection, makes available under summary.system_info
  • Add ability to select output file format between TOML and JSON
  • Add ability to POST request to remote API
  • Add ability to save payload body to a file for debugging
  • Capability to add additional labels to --label to payload under payload's "labels" attribute

Copy link

semanticdiff-com bot commented Jan 24, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  src/bin/hardware_report.rs  13% smaller
  src/lib.rs  10% smaller
  .github/workflows/release.yml Unsupported file format
  .github/workflows/test.yml Unsupported file format
  Cargo.lock Unsupported file format
  Cargo.toml Unsupported file format
  src/posting.rs  0% smaller

Copy link
Contributor

@jeztek jeztek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some tests are failing but the overall changes look good to me! Will hold off on merge approval until tests pass and @kennethdsheridan gets a chance to review.

@knd2122
Copy link
Author

knd2122 commented Jan 24, 2025

Looks like some tests are failing but the overall changes look good to me! Will hold off on merge approval until tests pass and @kennethdsheridan gets a chance to review.

Just pushed in some fixes, it test should pass now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants