Fix "PHP message: TypeError: get_headers(): Argument #2 ($associative… #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ciative) must be of type bool, int given"
nodiscc
approved these changes
Jan 19, 2025
There was a problem hiding this comment.
Thanks, this should indeed be a boolean
https://www.php.net/manual/en/function.get-headers.php
Disregard failing checks, separate problem for which I will open a new issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message "PHP message: TypeError: get_headers(): Argument #2 ($associative) must be of type bool, int given"
pops from time to time in php logs, fix get_headers() call to comply with requirement.
Same fix should be applied to https://github.com/ArthurHoaro/web-thumbnailer/blob/master/src/Application/WebAccess/WebAccessPHP.php as it's pulled in the official zip installation archive.