src/: Prefer return over exit in main function #1201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling exit directly circumvents the stack protector of the main function. Assist the runtime in potentially detecting flaws without adjusting the code base too much. Signed-off-by: Tobias Stoeckmann <[email protected]>
Comment on lines
47
to
+50
| if (check_uids) { | ||
| if (have_sub_uids(owner, start, count)) | ||
| exit(0); | ||
| exit(1); | ||
| return 1; |
There was a problem hiding this comment.
For error handling, I very much prefer exit(3).
For successful exiting, I still have some preference for exit(3), but could be convinced of using return.
I think exit(3) has more readability, as it tells that the program is over, while with return you have to remember (and check) that you're in main().
BTW, right here there's a successful exit(3) call unchanged. :)
There was a problem hiding this comment.
I think we can close this PR. I'm not fully convinced but wanted to offer in case someone really wants this. So ... No. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argued with myself about creating this PR or not, so here are my pro and contra arguments:
return over exit
exit over return
Either/or
Keep as is
Since I created the PR, I see benefits in allowing the stack protector to work and unification process is always nice.
But let's not rush this. Small benefit anyway.