Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slovak language to emulator #2307

Closed

Conversation

SharkStudiosSK
Copy link

Add Slovak language to the language selection in the settings dialog.

  • Update the languages map in the InitializeEmulatorLanguages function to include "Slovak".
  • Update the languageIndexes vector to include the index for Slovak.

Add Slovak language to the language selection in the settings dialog.

* Update the `languages` map in the `InitializeEmulatorLanguages` function to include "Slovak".
* Update the `languageIndexes` vector to include the index for Slovak.
@DanielSvoboda
Copy link
Contributor

Some points that might be worth reviewing:

  1. You can't remove the 'reuse' header, add it back.
    image

  2. Two spaces were added there, you must format the 'clang' correctly for it to be correct.
    image

  3. 'Slovak' should be alphabetized
    image

  4. I believe that the number 31 should also be added to line 314
    image

  5. f you also want to add translation to the interface, you need to add a .ts file in the src/qt_gui/translations folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants