Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ru_RU translation for 6.0 #2318

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

f1amy
Copy link
Contributor

@f1amy f1amy commented Feb 1, 2025

Translated new strings, added new from source code, fixed some

Used this command to find new strings:

$ lupdate-qt6 ru_RU.ts ../ -ts ru_RU.ts -no-obsolete -no-sort -locations none

@f1amy
Copy link
Contributor Author

f1amy commented Feb 1, 2025

cc @GHU7924

Переводов для #1356 не нашел, похоже что нужно в коде все оборачивать в tr()
It seems #1356 has yet to be translated

@f1amy f1amy marked this pull request as ready for review February 1, 2025 16:04
@f1amy
Copy link
Contributor Author

f1amy commented Feb 1, 2025

Hmm, it seems this dialog has issues with translations:
image

@GHU7924
Copy link

GHU7924 commented Feb 1, 2025

Hmm, it seems this dialog has issues with translations: image

Так и думал)) Данное окно - первое, что мы видим, после никто, видимо, не заходил в Настройки - Каталог установки игры, а там можно увидеть что это окно не переведено.

Далее
Localization2

Есть ещё отсутствующие строки в описаниях. Потом, должна быть "Заглавная музыка" вместо "Играть заглавную музыку" (это ошибка осталась в английской локализации). Auto Select видимо также не доступен для перевода.
Вкладку "Графический интерфейс" можно было оставить просто как "Интерфейс", ибо менее громоздко.

Game is already running! Строка 552 - Игра уже запущенна! (одна "н")

@kalaposfos13 Can you adapt your PR 1356 for translations? We need to at least en.ts had access to your interface and text.
@DanielSvoboda It looks like we need your help again.

@f1amy Ошибки пока не ищу, смотрю везде ли присутствует локализация.

@DanielSvoboda
Copy link
Contributor

DanielSvoboda commented Feb 1, 2025

I noticed that several languages ​​have problems, I was waiting for these PRs that change the texts to start my correction, I would go through all the languages ​​making the corrections...
At the moment it seems that there are 3 PRs that are making corrections to translations
Is everything ok in ru_RU?

@f1amy f1amy marked this pull request as draft February 1, 2025 18:09
@f1amy
Copy link
Contributor Author

f1amy commented Feb 1, 2025

@GHU7924 Обновленные описания i forgor, сделаю.
Описание для "Играть заглавную музыку" отсылает к элементу галочки, а не раздела, так сделано везде

@DanielSvoboda I will make a few changes rn

@GHU7924
Copy link

GHU7924 commented Feb 1, 2025

@DanielSvoboda In that case, shouldn't we put the en.ts in order first?
Later, new localizations will be made based on it... It will add to the hassle, but in the end there will be order everywhere.

As a result, it is now necessary to review whether all the elements are available for translation, sort and arrange the elements.
Add comments where things are in the code, like:

// Toolbar
// File Menu (for an example)

	<message>
		<source>Open shadPS4 Folder</source>
		<translation>Open shadPS4 Folder</translation>
	</message>
	<message>
		<source>Recent Games</source>
		<translation>Recent Games</translation>
	</message>
	<message>
		<source>Exit</source>
		<translation>Exit</translation>
	</message>

// View Menu
The items from this menu are indicated here for translation.
// Settings Menu
The items from this menu are indicated here for translation.
// Help Menu
The items from this menu are indicated here for translation.

// Setting Window
// General Tab
The items from this menu are indicated here for translation.
...
...

What do you think?

- added translation for `Auto Select`
@f1amy f1amy marked this pull request as ready for review February 1, 2025 19:00
@f1amy
Copy link
Contributor Author

f1amy commented Feb 1, 2025

Updates descriptions, enabled translations on "Auto Select", should be ready now.

@kalaposfos13
Copy link
Contributor

@kalaposfos13 Can you adapt your PR 1356 for translations? We need to at least en.ts had access to your interface and text.

No, I don't really know how to write GUI code, if you haven't noticed, the entire frontend is basically a glorified text editor with some buttons, but I'm sure there will be people who will do that instead of me

@f1amy
Copy link
Contributor Author

f1amy commented Feb 2, 2025

@kalaposfos13 idk if this helps, to translate a string I just wrap them in tr('string') and that's it, it will be available for translation.
However for an editable bindings field in #1356, something more might needs to be done, as I assume the initial value is saved and then reused, preventing translations to be applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants