add quest target 5929

[journeym]

No description provided.

[journeym]

Please can you check what am I doing wrong?
Im trying to add an objective marker for quest https://database.turtle-wow.org/?quest=5929
for an npc Great Bear Spirit https://database.turtle-wow.org/?npc=11956

[shagu]

Hi, the problem is that manually adding things into the database, would revert it the next time I auto-generate the data.
I just fixed the druid bear quest for turtle wow using the overwrites: shagu/pfQuest-turtle@e311e76

For pfQuest itself, there's no overwrites yet, and it would be preferred to teach the extractor.lua how to detect it.

[journeym]

I dont get it
Quest is not exclusive to Turtle wow
https://www.wowhead.com/classic/quest=5929/great-bear-spirit
Whats the point in making chages to turtle quest module?
Yes, after your chages everything started working, but i still dont understand the structure needed to add quests, is this explained somewhere, because my solution didn't work form me for some reason.

[shagu]

I added it there, so that at least turtle-wow users see it for now (which i think is better than nobody seeing it).

pfQuest doesn't yet have an overwrites.lua that would allow to patch the auto-generated database.
To have that quest in pfQuest you'd need to update https://github.com/shagu/pfQuest/blob/master/toolbox/extractor.lua so that it picks up the proper data from the VMaNGOS database.
(Or introduce an overwrites.lua to pfQuest that allows to perform hacky additions to the database.)

How the database is built each time CMaNGOS or VMaNGOS adds new major changes, is explained here:
https://github.com/shagu/pfQuest/tree/master/toolbox

[shagu]

but i still dont understand the structure needed to add quests, is this explained somewhere, because my solution didn't work form me for some reason.

Maybe you picked the wrong quest ID? There are two of them, one for alliance and one for horde (5929 and 5930).
The syntax looks okay to me, so it should have worked if you used the correct faction.

[Artur91425]

Or introduce an overwrites.lua to pfQuest that allows to perform hacky additions to the database.

Very good idea. Add this file to make it easier for users to modify and add data to the database.

Temporary manually fixes can be integrated into this file and subsequently analyzed to correct errors and improvements extractor.lua