Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

And fences highlight #88

Merged
merged 2 commits into from
Sep 8, 2024
Merged

And fences highlight #88

merged 2 commits into from
Sep 8, 2024

Conversation

williamdes
Copy link
Contributor

No description provided.

@williamdes
Copy link
Contributor Author

Hello @shalzz
What do you think about this small change ?

@shalzz
Copy link
Owner

shalzz commented Sep 8, 2024

Hi, this looks like a more fine grained permissions control, which is fine if you want to have it in your own workflow.
In the example I want to keep it simple for people using the action.

It's reasonable for them to go through the settings to enable write permissions. Something people overlook is that you need to know how to use github actions before you try an actual action. I cannot replicate the whole GH actions manual/documentation here.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@williamdes williamdes changed the title Improve workflows with permissions and fences highlight And fences highlight Sep 8, 2024
@williamdes
Copy link
Contributor Author

Hi, this looks like a more fine grained permissions control, which is fine if you want to have it in your own workflow. In the example I want to keep it simple for people using the action.

It's reasonable for them to go through the settings to enable write permissions. Something people overlook is that you need to know how to use github actions before you try an actual action. I cannot replicate the whole GH actions manual/documentation here.

Okay, I understand this. I removed the permissions changes, the PR should be okay now ?

@shalzz shalzz merged commit 4abce24 into shalzz:master Sep 8, 2024
5 checks passed
@shalzz
Copy link
Owner

shalzz commented Sep 8, 2024

Yes, thanks and merged.

@williamdes williamdes deleted the williamdes-workflows branch September 8, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants