Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generate shell completions on build #214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FilipRazek
Copy link
Contributor

My attempt at closing #155

@FilipRazek FilipRazek force-pushed the generate-shell-completions branch 4 times, most recently from 1fade95 to 5507857 Compare January 25, 2024 11:51
@sharkdp
Copy link
Owner

sharkdp commented Jan 27, 2024

Thank you very much!

It would be great if we could also integrate the generated shell completion files in the artifacts we built when we make a release. You can find examples how we do this in some other projects of mine, like hyperfine (see this file and search for complete/completion) and search for complete/completion)

@FilipRazek FilipRazek force-pushed the generate-shell-completions branch 2 times, most recently from 49d3c82 to 2a4d8fc Compare February 22, 2024 20:23
@FilipRazek
Copy link
Contributor Author

Thanks for the hint, I tried to update the CICD file, tell me if this would work for you

@sharkdp
Copy link
Owner

sharkdp commented Feb 24, 2024

You can find the generated artifacts here at the bottom: https://github.com/sharkdp/hexyl/actions/runs/8010537770

@FilipeBento
Copy link

Hello! Will this go through? 😄 (I don't have enough knowledge to implement this on my own, I'm sorry)

@sharkdp
Copy link
Owner

sharkdp commented Sep 8, 2024

@FilipRazek Sorry for not coming back to this. Would it be possible to update this to the latest state of master? I'd love to integrate this.

@FilipRazek
Copy link
Contributor Author

I'm sorry, I don't know how to integrate clap_complete with the new API. I will look into it but it doesn't seem to be a straightforward change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants