Typescript experiment #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'll see if I can get time to test it but I don't know at the moment. Anyway, there aren't formal tests for this library right now, but I think by running the example script after importing the local TypeScript files, we can see if things work. I am almost certain that something is broken though because it's been 2 years, and Google's UI has almost definitely changed. |
|
I tried just that and yeah we got issues when logging in the account. i'll try to fix the issue for now. I also added an env so that anyone can just fill in their google credentials for testing without getting it accidentally committed, it would be bad if your credential can be read from git history 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added typescript support for now. but i have no idea how to test if it still works or not