Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update orchestrate.rb #152

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update orchestrate.rb #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/pg_online_schema_change/orchestrate.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def setup_store
# Set this early on to ensure their creation and cleanup (unexpected)
# happens at all times. IOW, the calls from Store.get always return
# the same value.
Store.set(:old_primary_table, "pgosc_op_table_#{client.table.downcase}")
Store.set(:old_primary_table, "pgosc_op_table_#{client.table.downcase}_#{pgosc_identifier}")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the spec is failing due to the length. We would like to keep this length to 20 or maybe 21 characters, to not accidentally overflow in case the actual table name is longer and then result into production errors, since PG has a table name length limit.

Do you want to see if you can repurpose the logic here to perhaps add an index (numeric). For example pgosc_op_table_foobar_1.

Note: If _1 already exists, then it should automatically increment the index from the previous value.

It requires updating a few code paths and specs, so I am happy to take it over too. Let me know 🙌🏾

Store.set(:audit_table, "pgosc_at_#{client.table.downcase}_#{pgosc_identifier}")
Store.set(:operation_type_column, "operation_type_#{pgosc_identifier}")
Store.set(:trigger_time_column, "trigger_time_#{pgosc_identifier}")
Expand Down
Loading