Skip to content

Commit

Permalink
Expose the deployment strategy values for the policy controller
Browse files Browse the repository at this point in the history
Prior to this change, the policy controller webhook was not able to have
its deployment strategy modified. If you only deployed a single replica,
it could not perform a rolling update due to the default `maxSurge:
25%` being rounded down to 0.

This change exposes those values, so that the `maxSurge` can be updated
and a single instance can be rolled.

Fixes sigstore#748.

Signed-off-by: Alex Shearn <[email protected]>
  • Loading branch information
shearn89 committed May 8, 2024
1 parent a9557ed commit 5505f6d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
3 changes: 1 addition & 2 deletions charts/policy-controller/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ The Helm chart for Policy Controller
| webhook.failurePolicy | string | `"Fail"` | |
| webhook.image.pullPolicy | string | `"IfNotPresent"` | |
| webhook.image.repository | string | `"ghcr.io/sigstore/policy-controller/policy-controller"` | |
| webhook.image.version | string | `"sha256:f291fce5b9c1a69ba54990eda7e0fe4114043b1afefb0f4ee3e6f84ec9ef1605"` | `"v0.8.2"` |
| webhook.image.version | string | `"sha256:f291fce5b9c1a69ba54990eda7e0fe4114043b1afefb0f4ee3e6f84ec9ef1605"` | |
| webhook.name | string | `"webhook"` | |
| webhook.namespaceSelector.matchExpressions[0].key | string | `"policy.sigstore.dev/include"` | |
| webhook.namespaceSelector.matchExpressions[0].operator | string | `"In"` | |
Expand Down Expand Up @@ -71,7 +71,6 @@ The Helm chart for Policy Controller
| webhook.webhookNames.defaulting | string | `"defaulting.clusterimagepolicy.sigstore.dev"` | |
| webhook.webhookNames.validating | string | `"validating.clusterimagepolicy.sigstore.dev"` | |


### Deploy `policy-controller` Helm Chart

Install `policy-controller` using Helm:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@ spec:
matchLabels:
{{- include "policy-controller.selectorLabels" . | nindent 6 }}
control-plane: {{ template "policy-controller.fullname" . }}-webhook

{{- if .Values.deployment.strategy }}
strategy:
{{ toYaml .Values.deployment.strategy | trim | indent 4 }}
{{ if eq .Values.deployment.strategy.type "Recreate" }}rollingUpdate: null{{ end }}
{{- end }}

template:
metadata:
labels:
Expand Down

0 comments on commit 5505f6d

Please sign in to comment.