-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated ReadMe and added Udemy and DailyDev #2331
Conversation
In case installation fails: | ||
```bash | ||
python -m sherlock_project user1 user2 user3 | ||
``` | ||
or | ||
```bash | ||
python3 -m sherlock_project user1 user2 user3 | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain this section please?
Python's gotta get it from somewhere, and that would presumably be by installation (which either failed or didn't)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure why only this method works for me, but I'm guessing even if the installation is somewhat successful, running it by directly calling the module with Python bypasses permission or setup issues.
"DailyDev":{ | ||
"errorType": "message", | ||
"errorMsg":"Page not found.", | ||
"url": "https://app.daily.dev/{}", | ||
"urlMain": "https://app.daily.dev/", | ||
"username_claimed": "nj05" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Returns positive for all queries
errorType
of message
should be a last resort behind status_code due to l10n issues
"udemy": { | ||
"errorMsg": "Page not found", | ||
"errorType": "message", | ||
"url":"https://www.udemy.com/user/{}", | ||
"urlMain": "https://www.udemy.com/", | ||
"username_claimed": "adfadf" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Returns positive for all queries
errorType
of message
should be a last resort behind status_code due to l10n issues
@@ -2777,6 +2784,13 @@ | |||
"urlMain": "https://www.toster.ru/", | |||
"username_claimed": "adam" | |||
}, | |||
"udemy": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please capitalize for UX (minor bikeshed maybe)
Updated ReadME to include 1 line python commands to run sherlock without direct installation.
Added Udemy and DailyDev to the list of websites.