Skip to content

Commit

Permalink
DataViews: update search input placeholder (WordPress#58742)
Browse files Browse the repository at this point in the history
Co-authored-by: jameskoster <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: oandregal <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
  • Loading branch information
5 people authored Feb 7, 2024
1 parent 5b4286a commit 30b4349
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion packages/dataviews/src/search.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const Search = memo( function Search( { label, view, onChangeView } ) {
search: debouncedSearch,
} );
}, [ debouncedSearch ] );
const searchLabel = label || __( 'Filter list' );
const searchLabel = label || __( 'Search' );
return (
<SearchControl
__nextHasNoMarginBottom
Expand Down
8 changes: 4 additions & 4 deletions test/e2e/specs/site-editor/new-templates-list.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@ test.describe( 'Templates', () => {
} );
await admin.visitSiteEditor( { path: '/wp_template/all' } );
// Global search.
await page.getByRole( 'searchbox', { name: 'Filter list' } ).click();
await page.keyboard.type( 'tag' );
await page.getByRole( 'searchbox', { name: 'Search' } ).fill( 'tag' );
const titles = page
.getByRole( 'region', { name: 'Template' } )
.getByRole( 'link', { includeHidden: true } );
Expand All @@ -72,8 +71,9 @@ test.describe( 'Templates', () => {

// Filter by author and text.
await page.getByRole( 'button', { name: 'Reset filters' } ).click();
await page.getByRole( 'searchbox', { name: 'Filter list' } ).click();
await page.keyboard.type( 'archives' );
await page
.getByRole( 'searchbox', { name: 'Search' } )
.fill( 'archives' );
await expect( titles ).toHaveCount( 3 );
await page
.getByRole( 'button', { name: 'Filters', exact: true } )
Expand Down

0 comments on commit 30b4349

Please sign in to comment.