Skip to content

Commit

Permalink
fix: remove broken workaround
Browse files Browse the repository at this point in the history
  • Loading branch information
0t4u committed Oct 29, 2024
1 parent 4f5bc2b commit aa3f7db
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 18 deletions.
17 changes: 2 additions & 15 deletions src/etc/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
import path from 'path';
import fs from 'fs-extra';
import semver from 'semver';
import { version, semanticAlias, versionsOptions, metadata } from '../types';
import { Application, Logger, TypeDocReader } from 'typedoc';
import { version, semanticAlias, metadata } from '../types';
import { Application } from 'typedoc';
const packagePath = path.join(process.cwd(), 'package.json');
const pack = fs.readJSONSync(packagePath);

Expand Down Expand Up @@ -392,19 +392,6 @@ export function getSymlinkVersion(symlink: string, docRoot: string): version {
}
}

/**
* Workaround for [#2024](https://github.com/TypeStrong/typedoc/issues/2024)
* @param app
* @returns correctly overridden options
*/
export function getVersionsOptions(app: Application): versionsOptions {
const defaultOpts = app.options.getValue('versions') as versionsOptions;
app.options.addReader(new TypeDocReader());
app.options.read(new Logger());
const options = app.options.getValue('versions') as versionsOptions;
return { ...defaultOpts, ...options };
}

/**
* Resolve the root document path and document build path
* @param app
Expand Down
6 changes: 3 additions & 3 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,17 @@ export function load(app: Application) {
app.options.addDeclaration({
help: 'Options for typedoc-plugin-versions',
name: 'versions',
type: ParameterType.Mixed,
type: ParameterType.Object,
defaultValue: {
stable: 'auto',
dev: 'auto',
domLocation: 'false',
packageFile: 'package.json',
makeRelativeLinks: false,
} as versionsOptions,
},
});

const vOptions = vUtils.getVersionsOptions(app) as versionsOptions;
const vOptions = app.options.getValue("versions") as versionsOptions;

vHooks.injectSelectJs(app);
vHooks.injectSelectHtml(app, vOptions.domLocation);
Expand Down

0 comments on commit aa3f7db

Please sign in to comment.