Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Ruin: Tesla Lab #3787

Open
wants to merge 56 commits into
base: master
Choose a base branch
from
Open

New Ruin: Tesla Lab #3787

wants to merge 56 commits into from

Conversation

Erikafox
Copy link
Contributor

About The Pull Request

Adds a new ruin to the iceplanet ruin pool - Tesla Lab

Screencaps

image
StrongDMM-2024-11-16 15 39 07
StrongDMM-2024-11-16 15 39 08

Why It's Good For The Game

This is an very hard ruin filled with nefarious tricks and a decent bit of loot. I want it to challenge people.

Changelog

🆑
add: CLIP has lost contact with a facility in the system. Go find it. Go see what happened. I dare you.
/:cl:

@Erikafox Erikafox requested review from FalloutFalcon and a team as code owners November 16, 2024 20:42
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. DME Edit Ship Ship successfully tested. Code change Watch something violently break. Ruin Ruin successfully tested. labels Nov 16, 2024
Copy link
Contributor

@Gristlebee Gristlebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • since these are secure containment areas, I think it'd make sense if they had blastdoors for the windows. The tesla observation room also has no lighting.
    image
    image
  • these are all active turfs. Use planetary atmos subtypes please. The room also has no lighting.
    image
  • no lighting in the jani closet or toilet.
    image
  • there's no lighting in this washroom as well.
    image
  • the holofields in the subshuttle are not anchored. Use the roundstart subtype.
    image
  • Exterior windows should have shutters I feel.
    image
  • same issue with the compound entrance holofields.
    image
  • the railing overlays on top of the medkits in the subshuttle medbay
    image
  • missing a wire here between subshuttle holofields and the SMES
    image
    image
  • the compound holofields aren't properly wired either.
    image
    • The compound entrance holofields and subshuttle portside holofields share the same IDs.
  • the office has no buttons for the door and windows shutters.
    image
  • the turrets on the subshuttle shoot the frontiersmen simplemobs as they dont have the frontiersmen faction set.
  • the turrets wont target heads of staff.
    image
  • the tapes in here don't play back properly. They start, but never begin playing back the recording.
    image
  • this should be a proper cycle airlock if you're planning on making the tesla room airless.
    image
  • the tesla anomaly engine is cool, but doesn't actually generate much in the way of power, and with such a large ruin it tends to burn through all it's stored power fast which is a concern. Maybe put some more SMESes with extra charge, though if you have another solution in mind you want to go with that's fine.
    image
  • the blood freezer is empty. I notice you set the populate to false, so maybe toss around some empty blood bags to imply they used up the blood so there's a bit more substance too it.
    image
  • Another empty crate here in the cargo bay. Put something in, or have it start open to imply it's been looted like the other crates.
    image
  • the desynchronizers are fun and it's nice to see them actually used. I'd say cut down the amount mapped to one or two though.
    image

Copy link
Contributor

@Gristlebee Gristlebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • You added shutters to the tesla room like I asked in the previous review, but not the static anomaly room. Is that intentional?
    image
  • You sealed off the room, which does solve the issue of active turfs, but does limit the amount of the ways you can enter the ruin and makes it a lot more linear. I do think it would be more interesting if you had it be open like before but with planetary turfs. There's also still no lights from what I can see.
    image
  • Shutters and buttons in the office also have the wrong ID.
    image
    image
  • Stray light in the SMES room
    image
  • Cycle airlock here as I asked for in the previous review unless you have a reason as for otherwise. I'm blind, there is one.
    image
  • You don't seem to have changed the faction on the turrets on the subshuttle from what I can tell so they're still gonna target the frontiersmen simple mobs around.
  • Doing a check on the loot, the amount of frontiersmen that will drop their guns is concerning. I'd say set 4 of the shotgunners, 3 of the mosins, 1 of the SKM guys to neuter so they dont drop guns and the rest can drop their guns. I do get you want it to be a ruin with good loot for the challenge, but this is a lot of guns as is right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit Map Change Tile placing is hard. Thank you for your service. Ruin Ruin successfully tested. Ship Ship successfully tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants