-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Substitutes Asimov with Crewsimov + Cyborg fixes. #3799
base: master
Are you sure you want to change the base?
Conversation
This reverts commit 6ae2f9a.
As this is one of my largest PRs to date, any and all feedback is appreciated! I understand that this is a big change, and I can adjust anything as requested. |
So, here's the thing. We don't really use any of the silicon laws, nor really have an interest in dealing with them administratively. The repo config isn't up to date with server config, either, which is on us. The current law we use is: I don't really have any interest in changing this. A silicon here is considered part of the ship's crew, and isn't really bound to a strict set of laws in our setting. None of these law changes would be used if they were to be merged, and I'd like to keep it that way. Silicon stuff is a headache and generally designed to cause friction with a station's crew - this is not really applicable to us If you'd like to keep some cyborg changes that's fine, but the law stuff will not be getting merged. |
What if you just removed the law and have them start purged by default? I'm like 90% sure we're moving away from lawed silicons being a thing anyways, and functionally I don't think anything changes. |
@thgvr Would this be a better solution, do you think? If not, I'll scrap all the law stuff. |
About The Pull Request
Changes cyborgs and AIs to start with a new, fully-implemented law set: Crewsimov.
Security cyborgs have also seen their hailers removed, and peacekeepers have had their disappearing shield generators fixed. Both of their module select messages have been changed to reflect the Crewsimov default.
Why It's Good For The Game
For the fixes, the cyborg hailer was only used for playing sounds that were removed as cruft in a previous pr, and the shield icon state was made invisible by a single misplaced character. Crewsimov, otherwise, is a huge improvement on the default Asimov to protect all manner of the humanoid crew that constructs an AI or cyborg on their ship instead of any random human.
Changelog
🆑
add: Crewsimov, a crew-focused Asimov! Crewsimov boards can be researched and printed under the AI node.
del: Removes the useless sec hailer from security cyborgs.
tweak: Changes the peacekeeper and security module's messages to reflect a Crewsimov default.
fix: The hyperkinetic dampening projector now changes icon states appropriately.
config: Replaces Asimov with Crewsimov in many places, including as the default law set.
/:cl: