Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real 9mm fix #3804

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

SomeguyManperson
Copy link
Contributor

@SomeguyManperson SomeguyManperson commented Nov 19, 2024

About The Pull Request

Fixes #3772

Why It's Good For The Game

Changelog

🆑
fix: 9mm AP boxes now work right
/:cl:

@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Ship Ship successfully tested. Code change Watch something violently break. Ruin Ruin successfully tested. labels Nov 19, 2024
name = "box of AP 9mm ammo"
desc = "A box of 9mm armor-piercing ammo, designed to penetrate through armor at the cost of total damage."
icon_state = "9mmbox-ap"

/obj/item/storage/box/ammo/c9mm/ap/PopulateContents()
/obj/item/storage/box/ammo/c9mm_ap/PopulateContents()
..()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this call does nothing you should just removee it instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need the parent call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Ruin Ruin successfully tested. Ship Ship successfully tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9mm AP ammo boxes from Cargo come half loaded with normal 9mm.
3 participants