Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync documentation from shipwright-io/build at v0.14.0 level #140

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Sync documentation from shipwright-io/build at v0.14.0 level #140

merged 1 commit into from
Dec 10, 2024

Conversation

SaschaSchwarze0
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 commented Nov 21, 2024 •
edited
Loading

Changes

This PR syncs the documentation pages from the v0.14.0 tag of Shipwright Build.

Also fixing broken links in the release blog post.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

Documentation updated to v0.14.0

@SaschaSchwarze0 SaschaSchwarze0 added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 21, 2024
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.14.0 milestone Nov 21, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 21, 2024
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-docs-v0.14.0 branch 8 times, most recently from a2e8d56 to f51fa9b Compare November 21, 2024 19:46
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 21, 2024
HeavyWombat
HeavyWombat reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@HeavyWombat HeavyWombat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing: In the release notes, I think there is a TYPO, it's "Documentation". Otherwise /lgtm

@SaschaSchwarze0
Copy link
Member Author

Just one small thing: In the release notes, I think there is a TYPO, it's "Documentation". Otherwise /lgtm

Ty.

qu1queee
qu1queee approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@qu1queee
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 88bcea1 into shipwright-io:main Dec 10, 2024
6 checks passed
@adambkaplan adambkaplan mentioned this pull request Dec 12, 2024
Closed
1 task
This was referenced Dec 12, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeavyWombat HeavyWombat HeavyWombat left review comments

@qu1queee qu1queee qu1queee approved these changes

@rolfedh rolfedh Awaiting requested review from rolfedh

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

Assignees

@qu1queee qu1queee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Shipwright Overview
Status: Done
Milestone
release-v0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SaschaSchwarze0 @qu1queee @HeavyWombat