Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] simplify counting search results #1090

Merged
merged 1 commit into from
Sep 9, 2024
Merged

[core] simplify counting search results #1090

merged 1 commit into from
Sep 9, 2024

Conversation

shish
Copy link
Owner

@shish shish commented Feb 24, 2024

[core] simplify counting search results

SELECT images.* vs SELECT COUNT(*)

@shish shish mentioned this pull request Feb 24, 2024
Draft
@shish
Copy link
Owner Author

shish commented Feb 24, 2024

(Also TIL that COUNT(*) is literally interpreted as "count the number of rows" and it doesn't load all of the columns from disk despite what the * might imply, it can actually be faster than COUNT(id))

@discomrade
Copy link
Contributor

This will need to be re-written for it to work with #1153

@shish
[core] simplify counting search results
ce44330 
`SELECT images.*` vs `SELECT COUNT(*)`
@shish shish merged commit 4aafb01 into main Sep 9, 2024
24 checks passed
@shish shish deleted the pr1090 branch September 9, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shish @discomrade