fix(setting panel): typo

shiyiya · Jul 28, 2024 · 4dd967c · 4dd967c
1 parent 65ec349
commit 4dd967c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/ui/package.json b/packages/ui/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@oplayer/ui",
-  "version": "1.3.3-beta.1",
+  "version": "1.3.3-beta.2",
   "description": "ui plugin for oplayer",
   "type": "module",
   "main": "./dist/index.es.js",

diff --git a/packages/ui/src/components/Setting.ts b/packages/ui/src/components/Setting.ts
@@ -114,7 +114,7 @@ function createRow({
 }) {
   let $item: HTMLElement = $.create(`div.${settingItemCls}`, {
     'data-key': key,
-    role: Boolean(type) ? 'menuitem' : 'menuitemradio',
+    role: type == 'option' ? 'menuitemradio' : 'menuitem',
     'aria-haspopup': type == 'selector'
   })
   const res = {
@@ -254,7 +254,7 @@ function createPanel(
         type == 'selector' && children.every((it) => !Boolean(it.type) || it.type == 'option')
 
       const optionPanel = createPanel(player, panels, children, {
-        key: key || 'name',
+        key: key || name,
         target,
         parent: panel,
         isSelectorOptionsPanel: nextIsSelectorOptionsPanel,