Skip to content

Commit

Permalink
[shopsys] upgrade easy coding standards (#3192)
Browse files Browse the repository at this point in the history
  • Loading branch information
grossmannmartin authored Jun 4, 2024
2 parents a47f979 + b3dad4f commit 2e83ff1
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 54 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/run-checks-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,5 @@ jobs:
tools: composer
- name: Install Composer dependencies
run: composer install --optimize-autoloader --no-interaction
- name: Run parallel-lint
run: php vendor/bin/parallel-lint ./src ./tests
- name: Run Easy Coding Standards
run: php vendor/bin/ecs check --verbose ./src ./tests
- name: Run PHPUnit
run: php vendor/bin/phpunit tests
6 changes: 2 additions & 4 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,11 @@
"twig/twig": "^3.5.0"
},
"require-dev": {
"phpunit/phpunit": "^9.5.20",
"shopsys/coding-standards": "15.0.x-dev"
"phpunit/phpunit": "^9.5.20"
},
"config": {
"allow-plugins": {
"symfony/flex": true,
"dealerdirect/phpcodesniffer-composer-installer": true
"symfony/flex": true
}
}
}
46 changes: 0 additions & 46 deletions ecs.php

This file was deleted.

1 change: 1 addition & 0 deletions src/Form/GoogleProductFormType.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)
->addEventListener(FormEvents::POST_SET_DATA, function (FormEvent $event) {
// Setting default value of multidomain form "show" to true via event because of dynamic form count
$multidomainShowForm = $event->getForm()->get('show');

/** @var \Symfony\Component\Form\FormInterface $showForm */
foreach ($multidomainShowForm as $showForm) {
if ($showForm->getData() === null) {
Expand Down

0 comments on commit 2e83ff1

Please sign in to comment.