Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain new twig changes while keeping appropriate warnings #1500

Open
wants to merge 2 commits into
base: next-6.7
Choose a base branch
from

Conversation

JoshuaBehrens
Copy link
Contributor

I added new Twig stuff in this pull request. These are the docs for it.

@Isengo1989
Copy link
Collaborator

Follow up PR currently planned for 6.7 - shopware/shopware#5869

Milestone added but needs to be adjusted if version changes @BrocksiNet

@Isengo1989 Isengo1989 added this to the v6.7.0.0 milestone Dec 18, 2024
@JoshuaBehrens
Copy link
Contributor Author

Everything else is fine? Then I just bump the versions :)

@Isengo1989
Copy link
Collaborator

Isengo1989 commented Feb 12, 2025

Everything else is fine? Then I just bump the versions :)

From DX perspective, yes 👍 Maybe fix the conflict, seems to be only minor (from markdown fixes)

We might just change the target branch to next-6.7

Anything else @BrocksiNet from the technical side?

@bojanrajh bojanrajh changed the base branch from main to next-6.7 February 13, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Block PRs from merging hacktoberfest-accepted PR is accepted by us for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants