Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SG-17191 Added the ability to flag certain includes as optional #765

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

SG-17191 Added the ability to flag certain includes as optional #765

wants to merge 13 commits into from

Commits on Apr 17, 2020

  1. Added the ability to flag certain includes as optional

    @eshokrgozar
    eshokrgozar committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    938df9b View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2020

  1. Switched the 'optional' flag to 'required'. Added tests

    @eshokrgozar
    eshokrgozar committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    79ffb50 View commit details
    Browse the repository at this point in the history

  2. switched from using e.message to str(e)

    @eshokrgozar
    eshokrgozar committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    c91f977 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2020

  1. Removed unused portion of code for template includes. Combined the te… 

    …mplate and environment _get_include methods into one.
    @eshokrgozar
    eshokrgozar committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    b67fcd6 View commit details
    Browse the repository at this point in the history

  2. Fixed old tests to work with the new setup

    @eshokrgozar
    eshokrgozar committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    aea4880 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2020

  1. Made tests more robust as per PR comments. Moved tests to test_includ… 

    …es.py
    @eshokrgozar
    eshokrgozar committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    fe582a4 View commit details
    Browse the repository at this point in the history

  2. Made _get_includes public. Added docstrings to tests. Fixed StringIO … 

    …import issue for python 3
    @eshokrgozar
    eshokrgozar committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    d484e4e View commit details
    Browse the repository at this point in the history

  3. Added specific exception handling for import

    @eshokrgozar
    eshokrgozar committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    1965ee4 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2020

  1. Trying a fix for broken tests

    @eshokrgozar
    eshokrgozar committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    3a73bcc View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. Fixed broken test

    @eshokrgozar
    eshokrgozar committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    ab79a86 View commit details
    Browse the repository at this point in the history

  2. Fixed broken test

    @eshokrgozar
    eshokrgozar committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    d054edc View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2020

  1. Switched the test include to a relative path so it behaves the same o… 

    …n different operating systems
    @eshokrgozar
    eshokrgozar committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    b675eb6 View commit details
    Browse the repository at this point in the history

  2. Removed specific path from test because of slash direction mismatch b… 

    …etween windows and unix
    @eshokrgozar
    eshokrgozar committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    fb60e4c View commit details
    Browse the repository at this point in the history