Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to allow custom Descriptors via hooks #768

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Commits on May 26, 2020

  1. Add a new error type RegisterDescriptorError

    This error type my be thrown when registering custom descriptors
    Alex committed May 26, 2020
    Configuration menu
    Copy the full SHA
    348212b View commit details
    Browse the repository at this point in the history
  2. Don't automatically register our core types

    Alex committed May 26, 2020
    Configuration menu
    Copy the full SHA
    752ff06 View commit details
    Browse the repository at this point in the history
  3. Add our default RegisterDescriptors hook

    This is equivilent to the default tank.descriptor.io_descriptor init
    method.
    Alex committed May 26, 2020
    Configuration menu
    Copy the full SHA
    43d4986 View commit details
    Browse the repository at this point in the history
  4. Fix error imports from tank.descriptor.errors

    Alex committed May 26, 2020
    Configuration menu
    Copy the full SHA
    835dc57 View commit details
    Browse the repository at this point in the history
  5. Update the _initialize_descriptor_factory functions

    Both functions now pass in the baseclass to register against.
    Alex committed May 26, 2020
    Configuration menu
    Copy the full SHA
    4702887 View commit details
    Browse the repository at this point in the history
  6. Update DescriptorManager & hooks for IO

    The hook has changed it's method from ``register_types`` to ``register_io_descriptors``.
    
    The base class of this hook will run the same shotgun logic as before by calling the method in the __init__ of ``tank.descriptor.io_descriptor``.
    
    ``_register_io_descriptor_hook`` to call the RegisterDescriptors hook ``register_io_descriptors`` via the DescriptorManager method.
    Alex committed May 26, 2020
    Configuration menu
    Copy the full SHA
    0fbdb4b View commit details
    Browse the repository at this point in the history

Commits on May 27, 2020

  1. First pass at some documentation as well

    Alex committed May 27, 2020
    Configuration menu
    Copy the full SHA
    f8fa8fb View commit details
    Browse the repository at this point in the history
  2. Update io_descriptor initialize on first use

    Alex committed May 27, 2020
    Configuration menu
    Copy the full SHA
    1780349 View commit details
    Browse the repository at this point in the history