-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal to allow custom Descriptors via hooks #768
base: master
Are you sure you want to change the base?
Proposal to allow custom Descriptors via hooks #768
Commits on May 26, 2020
-
Add a new error type RegisterDescriptorError
This error type my be thrown when registering custom descriptors
Alex committedMay 26, 2020 Configuration menu - View commit details
-
Copy full SHA for 348212b - Browse repository at this point
Copy the full SHA 348212bView commit details -
Don't automatically register our core types
Alex committedMay 26, 2020 Configuration menu - View commit details
-
Copy full SHA for 752ff06 - Browse repository at this point
Copy the full SHA 752ff06View commit details -
Add our default RegisterDescriptors hook
This is equivilent to the default tank.descriptor.io_descriptor init method.
Alex committedMay 26, 2020 Configuration menu - View commit details
-
Copy full SHA for 43d4986 - Browse repository at this point
Copy the full SHA 43d4986View commit details -
Fix error imports from tank.descriptor.errors
Alex committedMay 26, 2020 Configuration menu - View commit details
-
Copy full SHA for 835dc57 - Browse repository at this point
Copy the full SHA 835dc57View commit details -
Update the _initialize_descriptor_factory functions
Both functions now pass in the baseclass to register against.
Alex committedMay 26, 2020 Configuration menu - View commit details
-
Copy full SHA for 4702887 - Browse repository at this point
Copy the full SHA 4702887View commit details -
Update DescriptorManager & hooks for IO
The hook has changed it's method from ``register_types`` to ``register_io_descriptors``. The base class of this hook will run the same shotgun logic as before by calling the method in the __init__ of ``tank.descriptor.io_descriptor``. ``_register_io_descriptor_hook`` to call the RegisterDescriptors hook ``register_io_descriptors`` via the DescriptorManager method.
Alex committedMay 26, 2020 Configuration menu - View commit details
-
Copy full SHA for 0fbdb4b - Browse repository at this point
Copy the full SHA 0fbdb4bView commit details
Commits on May 27, 2020
-
First pass at some documentation as well
Alex committedMay 27, 2020 Configuration menu - View commit details
-
Copy full SHA for f8fa8fb - Browse repository at this point
Copy the full SHA f8fa8fbView commit details -
Update io_descriptor initialize on first use
Alex committedMay 27, 2020 Configuration menu - View commit details
-
Copy full SHA for 1780349 - Browse repository at this point
Copy the full SHA 1780349View commit details