Fix iterateFormatted typing issue when dealing with "maybe async iterables"
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shtaif
force-pushed
the
fix-iterate-formatted-typing
branch
from
00c55c0 to
bb57253
Compare
…le types correctly
shtaif
force-pushed
the
fix-iterate-formatted-typing
branch
from
bb57253 to
b361b3a
Compare
shtaif
pushed a commit
that referenced
this pull request
Jan 22, 2025
## [0.7.0](v0.6.0...v0.7.0) (2025-01-22) ### Features * `iterateFormatted`'s to also format given iterables' current values if present ([#56](#56)) ([9f6e47a](9f6e47a)) * export a `AsyncIterableSubject` type and add it along related references ([#54](#54)) ([39eae6f](39eae6f)) * **Iterate:** support initial value in function form ([#49](#49)) ([bfc1f09](bfc1f09)) * special handling for async iterables with a current value( [#55](#55)) ([01a30fc](01a30fc)) * **useAsyncIter:** allow initial value to be a function, called once on mount ([#48](#48)) ([9a7e9e4](9a7e9e4)) ### Bug Fixes * **iterateFormatted:** function's type signature does not not handle maybe-async-iterable kind of types correctly ([#57](#57)) ([f073d90](f073d90)) ### Documentation * docs edits ([#53](#53)) ([c5bfba4](c5bfba4)) * **readme:** Initial proper `README.md` ([#60](#60)) ([4e1c4a9](4e1c4a9))
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
iterateFormatted's type signature not handling "maybe async iterable" type of inputs correctly.