✨ [progress] add progress #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
higuaifan
reviewed
Mar 15, 2024
There was a problem hiding this comment.
defineCore in vue version has some "historical reasons".
I don't think this is necessary in react version.
higuaifan
reviewed
Mar 15, 2024
| export const leaf = leafPng; | ||
|
|
||
|
|
||
| export function useProgress(options: Options<{ |
There was a problem hiding this comment.
try this:
export function useProgress(props:ProgressProps)
higuaifan
reviewed
Mar 15, 2024
| @@ -0,0 +1,65 @@ | |||
| /** | |||
There was a problem hiding this comment.
copy file from vue version , you should update comments
higuaifan
reviewed
Mar 15, 2024
| useEffect(() => { | ||
| setValue(props.value ?? 0); | ||
| setMax(props.max ?? 100); | ||
| }, [props.value, props.max]); |
There was a problem hiding this comment.
should value and max use two useEffect?
Their changes don't seem to affect each other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Nature of this PR
🔗 Related Issue
💡 Background and Solution
✅ Pre-merge Checklist
❗️Please self-check and check all options.❗️