no-unused-colocated-location rule
#30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented the `no-unused-colocated-location` rule - will add test cases later; Made minor comment fixes to `no-renaming-operator.ts`
Codecov Report
@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 88.48% 89.71% +1.23%
==========================================
Files 19 20 +1
Lines 660 749 +89
Branches 89 127 +38
==========================================
+ Hits 584 672 +88
- Misses 75 76 +1
Partials 1 1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Reworked how the rule is implemented to avoid unnecessary checks and checking for messages being returned Added test cases for complete coverage
ImpregnableProgrammer
force-pushed
the
no-unused-colocated-location
branch
from
5568c38 to
a32afbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the
no-unused-colocated-locationrule - will add test cases later; Made minor comment fixes tono-renaming-operator.ts. (I renamed this branch for consistency, which is why the previous version of this pull request was closed). This new rule is quite complex and might require some clarification in terms of the ways messages can be "unwrapped" by recipients before it can be declared fully implemented for closing issue #8.