feat: implement extra compressed chunks #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
force-pushed
the
feat/compressed-chunks
branch
from
486978c
to
c26966e
Compare
This allows to keep more data in the circular buffer by compressing old chunks and keeping them around, so the overall memory consumption is smaller. Change is backwards compatible - by default compression is not used. Tests were refactored to use regular *testing.T. Added benchmarks for read and write operations. Writes are allocation-free, even when using compression (compression buffer is re-used): ``` goos: linux goarch: amd64 pkg: github.com/siderolabs/go-circular cpu: AMD Ryzen 9 5950X 16-Core Processor BenchmarkWrite/defaults-32 7848931 150.5 ns/op 0 B/op 0 allocs/op BenchmarkWrite/growing_buffer-32 7116709 144.3 ns/op 0 B/op 0 allocs/op BenchmarkWrite/compression-32 3042698 399.2 ns/op 0 B/op 0 allocs/op ``` Reads are not allocation-free, but each Reader has fixed allocation cost (decompression buffer is re-used): ``` goos: linux goarch: amd64 pkg: github.com/siderolabs/go-circular cpu: AMD Ryzen 9 5950X 16-Core Processor BenchmarkRead/defaults-32 99565 12682 ns/op 80 B/op 1 allocs/op BenchmarkRead/growing_buffer-32 88371 12327 ns/op 80 B/op 1 allocs/op BenchmarkRead/compression-32 3193 372417 ns/op 139425 B/op 3 allocs/op ``` Co-authored-by: Utku Ozdemir <[email protected]> Signed-off-by: Andrey Smirnov <[email protected]>
smira
force-pushed
the
feat/compressed-chunks
branch
from
c26966e
to
3c48c53
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to keep more data in the circular buffer by compressing old
chunks and keeping them around, so the overall memory consumption is
smaller.
Change is backwards compatible - by default compression is not used.
Tests were refactored to use regular *testing.T.
Added benchmarks for read and write operations.
Writes are allocation-free, even when using compression (compression
buffer is re-used):
Reads are not allocation-free, but each Reader has fixed allocation cost
(decompression buffer is re-used):