Pull request proxy frame #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
reviewed
May 8, 2024
| @@ -32,17 +32,21 @@ type rawCodec struct { | |||
| parentCodec grpc.Codec //nolint: staticcheck | |||
| } | |||
|
|
|||
| type frame struct { | |||
| type Frame struct { | |||
There was a problem hiding this comment.
I don't think we need to expose this type as public, we can keep it frame, and add an interface
type SizeableFrame interface {
FrameSize() int
}This way any interceptor can typecast the payload and see if it implements the interface.
There was a problem hiding this comment.
That makes sense. I can change my request to do that instead.
|
I'll push some changes to main, please squash your commits, make signed-off (no need to sign with GPG) and make sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed
proxy.frametoproxy.Frameand added aSize() intmethod to allow the proxy to measure data throughput in an interceptor.