feat: add GRPC reverse tunnel server #746
Draft
+242
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow Omni API clients to receive GRPC calls in the reverse direction, `Omni->Client`. Might be used by the infra providers, e.g., bare-metal infra provider. Signed-off-by: Utku Ozdemir <[email protected]>
utkuozdemir
force-pushed
the
grpc-tunnel
branch
from
ff970a4 to
8c4d44b
Compare
smira
reviewed
Nov 27, 2024
| @@ -3,6 +3,9 @@ module github.com/siderolabs/omni | |||
| go 1.23.3 | |||
|
|
|||
| replace ( | |||
| // todo: remove when merged | |||
| github.com/siderolabs/omni-infra-provider-bare-metal v0.0.0-20241014092637-c3e892b87244 => github.com/utkuozdemir/sidero-omni-infra-provider-bare-metal v0.0.0-20241021213554-cc93e594a0d2 | |||
There was a problem hiding this comment.
I think if we need an API, it should be common for all providers, and should either live in Omni or in a separate repo.
my 2 cents
There was a problem hiding this comment.
Yes you are right, I'll anyway keep this as draft until we make a decision.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Omni API clients to receive GRPC calls in the reverse direction,
Omni->Client. Might be used by the infra providers, e.g., bare-metal infra provider.Possibly related to #660.