chore: drop deprecated allowSchedulingOnMasters #10089
Merged
+12
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkuozdemir
approved these changes
Jan 6, 2025
utkuozdemir
reviewed
Jan 6, 2025
Drop deprecated `.cluster.allowSchedulingOnMasters` machine config field. Signed-off-by: Noel Georgi <[email protected]>
frezbo
force-pushed
the
chore/drop-deprecated-field
branch
from
f658628 to
32c67c2
Compare
dsseng
approved these changes
Jan 6, 2025
|
/m |
|
@frezbo can we please revert this change? I think we should keep backwards compatibility for the machine configuration, this field was available, yes, it is deprecated, but removing it would break upgrades from 1.8 to 1.9 for no real reason (I mean technically this extra field doesn't hurt). |
yeh, I can revert, I was thinking along the lines of keeping it forever 😅 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop deprecated
.cluster.allowSchedulingOnMastersmachine config field.